Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add: Vector logging service #295

Merged
merged 2 commits into from
Oct 3, 2020
Merged

Add: Vector logging service #295

merged 2 commits into from
Oct 3, 2020

Conversation

nlamirault
Copy link
Contributor

@nlamirault
Add: Vector logging service
af92d69 
Signed-off-by: Nicolas Lamirault <[email protected]>
mingrammer
mingrammer reviewed Sep 27, 2020
View reviewed changes
Copy link
Owner

@mingrammer mingrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about which category is better for this? logging vs aggregator

If we create the aggregator category, we should also move the onprem.logging.fluentd under the aggregator category.

@nlamirault
Copy link
Contributor Author

@mingrammer 👍 . I could update the PR and move fluentd into aggregator.

mingrammer
mingrammer approved these changes Oct 3, 2020
View reviewed changes
Copy link
Owner

@mingrammer mingrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mingrammer mingrammer merged commit c790ac4 into mingrammer:master Oct 3, 2020
@gabriel-tessier gabriel-tessier mentioned this pull request Jan 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mingrammer mingrammer mingrammer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nlamirault @mingrammer